Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(translate): add a way to get translations #63

Merged
merged 1 commit into from
May 30, 2017
Merged

feat(translate): add a way to get translations #63

merged 1 commit into from
May 30, 2017

Conversation

mbarbeau
Copy link
Member

@mbarbeau mbarbeau commented May 30, 2017 •
edited
Loading

languageService.translate.get('key') -> return observable

languageService.translate.instant('key') -> return value

cbourget
cbourget approved these changes May 30, 2017
View reviewed changes
Copy link
Collaborator

@cbourget cbourget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will do but, in the long term, I think it would be better to make the LanguageService inherit from the TranslateService.

@cbourget cbourget merged commit 1b0878f into master May 30, 2017
@mbarbeau mbarbeau deleted the translation branch May 31, 2017 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbourget cbourget cbourget approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbarbeau @cbourget