Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(action): add a way to reactively set an actionbar item's availab… #425

Merged
merged 3 commits into from
Sep 24, 2019

Conversation

cbourget
Copy link
Collaborator

…ility and css class

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)

  • Conditions and css classes on actionbar items are set/updated on demand.

What is the new behavior?

  • Actions can now have an availability and ngClass observables that remove the need for on-demand updates. This is much more flexible, easier to user and error proof.

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@mbarbeau mbarbeau merged commit d1eb9cd into master Sep 24, 2019
@mbarbeau mbarbeau deleted the action-condition-and-class branch September 24, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants