Track feature #422
Merged
Track feature #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 17, 2019 14:23
mbarbeau
pushed a commit
that referenced
this pull request
Sep 25, 2019
* feat(geo.layer.vector) add possibility to track a feature * fix(geo.layer.styleByAttribute) fix 0 value * feat(geo.layer.vector) possibility to track a feature on map * feat(geo.filter.trackfeature.button) add a good tooltip * feat(geo.layer) relocate button "trackFeature" * Update filter.module.ts * Update layer-item.component.html * Update vector-layer.interface.ts
mbarbeau
pushed a commit
that referenced
this pull request
Sep 25, 2019
* feat(geo.layer.vector) add possibility to track a feature * fix(geo.layer.styleByAttribute) fix 0 value * feat(geo.layer.vector) possibility to track a feature on map * feat(geo.filter.trackfeature.button) add a good tooltip * feat(geo.layer) relocate button "trackFeature" * Update filter.module.ts * Update layer-item.component.html * Update vector-layer.interface.ts
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
possibility to track a feature (center map on feature when feature added)
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information:
follow discussion #416
tested on a websocket datasource
'update mode' will have to be tested on vector layer. Websocket datasouce always 'add' feature because OL3 do not add feature when ID already exists (see doc https://openlayers.org/en/latest/apidoc/module-ol_source_Vector-VectorSource.html#addFeature)
Maybe a event on 'changefeature' will have to be created in the vector layer