Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchsource hashtag #371

Merged
merged 15 commits into from
Jul 25, 2019
Merged

Searchsource hashtag #371

merged 15 commits into from
Jul 25, 2019

Conversation

matrottier
Copy link
Contributor

@matrottier matrottier commented Jul 23, 2019

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?
possibility to use #hashtag with search (icherche and nominatim)
ex: "carol québec #bar" or "#ancienne_adresse 2525 laurier québec"
nominatim result are not very good, overpass API could be a solution

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@matrottier
Copy link
Contributor Author

merge after : #370

@matrottier matrottier marked this pull request as ready for review July 24, 2019 16:02
@mbarbeau mbarbeau merged commit e69276e into 1.0.0-alpha Jul 25, 2019
@mbarbeau mbarbeau deleted the searchsource_hashtag branch July 25, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants