Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search- selector - Swap from radio button to checkbox for search groups #348

Closed
pelord opened this issue Jun 7, 2019 · 2 comments
Closed

Search- selector - Swap from radio button to checkbox for search groups #348

pelord opened this issue Jun 7, 2019 · 2 comments
Labels
enhancement New features and improvements // Nouvelles fonctionnalités et améliorations

Comments

@pelord
Copy link
Member

pelord commented Jun 7, 2019 •
edited
Loading

Please tell us about your environment:

  • Igo Version:
    1.0.0-alpha.1
  1. Change the current radio button by checkbox and add a way to check/uncheck all search-selector
  2. Manage the search-selector by search-source instead of search-type
@pelord pelord changed the title Search- selector - change radio button to checkbox Search- selector - change radio button to checkbox and search groups Jun 7, 2019
@pelord pelord added the enhancement New features and improvements // Nouvelles fonctionnalités et améliorations label Jun 7, 2019
@cbourget
Copy link
Collaborator

cbourget commented Jun 7, 2019

We should not change it. Instead, allow radiobuttons OR checkboxes. The default behavior may be to use one or the other.

@pelord pelord changed the title Search- selector - change radio button to checkbox and search groups Search- selector - Swap from radio button to checkbox for search groups Jun 7, 2019
@mbarbeau
Copy link
Member

mbarbeau commented Aug 8, 2019

#375

@mbarbeau mbarbeau closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New features and improvements // Nouvelles fonctionnalités et améliorations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cbourget @mbarbeau @pelord