Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ALIAS to wms getfeatureinfo(gml), wfs and vector datasources #249

Merged
merged 4 commits into from
Dec 20, 2018

Conversation

pelord
Copy link
Member

@pelord pelord commented Dec 18, 2018

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
There is no way to provide alias to datasources.

What is the new behavior?

  1. By using the sourceFields param (also used for ogc-filter) , you can provide an alias to a field

"sourceFields": [
{"name": "fieldname", "alias": "fieldAlias"},
....
...
]}

  1. When you click on map to query the vector source, the result is now grouped with the layer title instead of a generic group name named "Clicked feature". e.g.
    Before:
    image

After:
image

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@mbarbeau mbarbeau merged commit 871be03 into master Dec 20, 2018
@mbarbeau mbarbeau deleted the wmsAliasOnGML2 branch December 20, 2018 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants