Issue #189 Print options fix #238
Conversation
| @@ -340,6 +342,8 @@ export class PrintService { | |||
| try { | |||
| this.addCanvas(doc, canvas, size, margins); | |||
| } catch (err) { | |||
| alert('2' + err.toString()); | |||
There was a problem hiding this comment.
Is this intended or you forgot to remove it?
There was a problem hiding this comment.
Forgot, just removed it
|
Good work, thank you! I think it would be better if there was some padding added the bottom of the slide toggle group because, as it is right now, it overlaps with the next field's placeholder. Also, I think it would look better if the labels were before the slide toggle but I don't have a strong opinion on that matter. It could very well stay like this.
|
|
Somehow padding wasn't applying well outside of the library app. I used margins instead, now looks like this:
I prefer the labels after personnally, it looks neater. If they aligned to the right it would be neat too but when the container is large it feels weird to have them to the right. |
|
Looks good! |
| mat-checkbox.horizontal-left span { | ||
| padding: 0 8px; | ||
| mat-slide-toggle ::ng-deep span { | ||
| font-size: 100% !important; |
There was a problem hiding this comment.
try to avoid using the 'important' keyword
| @@ -9,7 +9,8 @@ import { | |||
| MatInputModule, | |||
| MatFormFieldModule, | |||
| MatRadioModule, | |||
| MatCheckboxModule | |||
| MatCheckboxModule, | |||
There was a problem hiding this comment.
I think that the MatCheckboxModule and MatRadioModule modules are no longer useful
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
Issue #189
What is the new behavior?
Toggle options
Selectbox for orientation
Margins correction
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: