-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reseau transport quebec #176
Conversation
@@ -33,7 +33,7 @@ export class LoggingInterceptor implements HttpInterceptor { | |||
const msg = `${req.method} "${req.urlWithParams}" | |||
${ok} in ${elapsed} ms.`; | |||
|
|||
console.log(msg); | |||
// console.log(msg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "console.log" should not be commented. If you do not want the http call logs, you must remove the module import here: https://github.com/infra-geo-ouverte/igo2-lib/blob/master/demo/src/app/core/request/request.module.ts
providers: [ | ||
provideIChercheSearchSource(), | ||
provideDataSourceSearchSource(), | ||
provideReseauTransportsQuebecSearchSource()] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that "ReseauTransportQuebec" should not be provide by default.
ReseauTransportQuebec is a specific need. Does it have a place in this depot? Should we separate him ? Put it in the assembly of the lib ? In @igo2/qc ? In another completely independent depot ? |
Yes, I have discussed it with @pelord couple of days ago. What do you suggest? Does igo2-lib and its customized Quebec modules (such as ) can be integrated easily? If so, how? |
There will be no difficulty to integrate a Quebec module, just one more import. |
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Adding new search sources for the Quebec Provincial road network (municipal network excluded).
For expert user:
Every of these words/characters will not be used into the query & case insensitive. Based on this regex
(/auto|routes|route|km| |high|ways|way|roads|road|#|a-|-/gi, '')
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: