Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datasource): add layer source connection to CARTO and ArcGIS Rest services #174

Merged
merged 2 commits into from
Aug 21, 2018
Merged

Conversation

MohammedBouheraoua
Copy link
Contributor

@MohammedBouheraoua MohammedBouheraoua commented Aug 20, 2018

No description provided.

@MohammedBouheraoua MohammedBouheraoua changed the title feat(datasource): add layer source connection to CARTO and ArcGIS Res… feat(datasource): add layer source connection to CARTO and ArcGIS Rest services Aug 20, 2018
Copy link
Member

@mbarbeau mbarbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work ! It seems very good to me ! Just minor changes.

@@ -2,5 +2,6 @@ export * from './base64';
export * from './clipboard';
export * from './object-utils';
export * from './strenum';
export * from './stylegenerator';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this file esri-style-generator

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move also to geo/src/lib/datasource/utils.

import * as olstyle from 'ol/style';
import * as olproj from 'ol/proj';

export class StyleGenerator {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename EsriStyleGenerator

@mbarbeau mbarbeau merged commit 3976c45 into infra-geo-ouverte:master Aug 21, 2018
@mbarbeau
Copy link
Member

Thank you @MohammedBouheraoua

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants