-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(datasource): add layer source connection to CARTO and ArcGIS Rest services #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work ! It seems very good to me ! Just minor changes.
projects/utils/src/lib/index.ts
Outdated
@@ -2,5 +2,6 @@ export * from './base64'; | |||
export * from './clipboard'; | |||
export * from './object-utils'; | |||
export * from './strenum'; | |||
export * from './stylegenerator'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename this file esri-style-generator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move also to geo/src/lib/datasource/utils.
import * as olstyle from 'ol/style'; | ||
import * as olproj from 'ol/proj'; | ||
|
||
export class StyleGenerator { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename EsriStyleGenerator
Thank you @MohammedBouheraoua |
No description provided.