Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sass exports for themes and utils #1589

Merged
merged 2 commits into from
Jan 22, 2024
Merged

fix: sass exports for themes and utils #1589

merged 2 commits into from
Jan 22, 2024

Conversation

alecarn
Copy link
Collaborator

@alecarn alecarn commented Jan 22, 2024

Ajustement de path pour respecter la règle que tous les SASS devrait se retrouver dans le dossier src en mode distribution. Ce qui nous permet de rouler en local (symlink) comme en prod (distribution).

Breaking changes pour la nomenclature de l'export theming qui devient theme. Pour éviter les collisions lors de la résolutions de paths. Je passe le BREAKING CHANGES incognito vu qu'on doit être les seuls a utiliser les thèmes via les fichiers SASS.

@alecarn alecarn requested a review from pelord January 22, 2024 13:28
@pelord pelord merged commit 643d6fc into next Jan 22, 2024
4 checks passed
@pelord pelord deleted the fix-sass-exports branch January 22, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants