fix(geo): check catalog not undefined before loading items #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aziz-access
added
the
bug
alecarn
requested changes
Jan 17, 2024
| this.loadCatalogItems(this.catalog); | ||
| if (this.catalog) { | ||
| this.loadCatalogItems(this.catalog); | ||
| } |
There was a problem hiding this comment.
On ne semble pas régler le problème mais plutot éviter de la renvoyer. Rapidement ça me semble être un problème de concurence entre les deux observables. Il faudrait trouver un moyen de corriger ce problème
There was a problem hiding this comment.
Oui exactement, problème de concurrence, parfois this.catalog est undefined.
alecarn
approved these changes
Jan 18, 2024
|
@pelord Ready for review |
pelord
changed the title
pelord
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior? (You can also link to an open issue here)
this behavior related ti #1573
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: