Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if app_initializer is still required #1558

Open
pelord opened this issue Dec 21, 2023 · 4 comments · Fixed by #1563 or infra-geo-ouverte/igo2#1128
Open

Check if app_initializer is still required #1558

pelord opened this issue Dec 21, 2023 · 4 comments · Fixed by #1563 or infra-geo-ouverte/igo2#1128
Assignees
Labels
enhancement New features and improvements // Nouvelles fonctionnalités et améliorations
Milestone

Comments

@pelord
Copy link
Member

pelord commented Dec 21, 2023

Please tell us about your environment:

  • Igo Version:
    17.x +

Check if, in the demo and in igo2, it's still required to setup an app initilizer.

{ provide: APP_INITIALIZER, useFactory: appInitializerFactory, deps: [Injector, ApplicationRef], multi: true }
This checkup is required due to the merge of this PR.
#1551

@pelord
Copy link
Member Author

pelord commented Dec 21, 2023

A mon avis, c'Est pas nécessaire.. mais il faudrait tester sur des poste - performants. Vous aviez eu le problème lors de la mise en prod de vigilance.

@pelord
Copy link
Member Author

pelord commented Dec 21, 2023

J'ai validé dans le constructeur de l'appmodule le service était bien la.

@alecarn
Copy link
Collaborator

alecarn commented Jan 8, 2024

J'ai amélioré le comportement dans la PR des Standalones via deux commits (LIB et Assemblage)
225f808
infra-geo-ouverte/igo2@a971afe

Via le provideRootTranslation, on lie le TranslateModule de ngx-translate avec notre LanguageService. Celui-ci sera instancier à l'initialisation de l'application et s'occupe aussi d'instancier le TranslateService de ngx-translate

@alecarn
Copy link
Collaborator

alecarn commented Jan 10, 2024

Finalement, pour enlever le AppInitializerFactory cela nécessitait des changements sur le chargement de nos fichiers de translations. On règle du même coup, un problème de double téléchargements des fichiers de traductions.
#1563

@alecarn alecarn linked a pull request Jan 10, 2024 that will close this issue
@alecarn alecarn added this to the v17.0.0 milestone Jan 10, 2024
@alecarn alecarn added the enhancement New features and improvements // Nouvelles fonctionnalités et améliorations label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features and improvements // Nouvelles fonctionnalités et améliorations
Projects
None yet
2 participants