Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baselayer Switcher stay open without useStaticIcon #1534

Closed
alecarn opened this issue Dec 8, 2023 · 2 comments · Fixed by #1548
Closed

Baselayer Switcher stay open without useStaticIcon #1534

alecarn opened this issue Dec 8, 2023 · 2 comments · Fixed by #1548
Assignees
@aziz-access
Labels
bug Incorrect or unexpected behaviors // Anomalies de fonctionnement
Milestone
v16.2.0

Comments

@alecarn
Copy link
Collaborator

alecarn commented Dec 8, 2023

If we have two basemaps and we don't set the useStaticIcon the switcher stay open.
image
@alecarn alecarn added the bug Incorrect or unexpected behaviors // Anomalies de fonctionnement label Dec 8, 2023
@alecarn alecarn added this to the v16.2.0 milestone Dec 8, 2023
@aziz-access
Copy link
Contributor

aziz-access commented Dec 15, 2023 •
edited
Loading

@alecarn i need more information about the utility of this param useStaticIcon

@alecarn
Copy link
Collaborator Author

alecarn commented Dec 15, 2023

For useStaticIcon we can have an icon button or if false we show the first igo-mini-basemap. Test it to see the difference!

@aziz-access aziz-access self-assigned this Dec 18, 2023
@aziz-access aziz-access mentioned this issue Dec 18, 2023
Merged
2 tasks
@aziz-access aziz-access linked a pull request Dec 18, 2023 that will close this issue
fix(geo): Baselayer Switcher stay open without useStaticIcon #1548
Merged
2 tasks
@alecarn alecarn closed this as completed Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aziz-access aziz-access

Labels
bug Incorrect or unexpected behaviors // Anomalies de fonctionnement
Projects
None yet
Milestone
v16.2.0
Development

Successfully merging a pull request may close this issue.

fix(geo): Baselayer Switcher stay open without useStaticIcon infra-geo-ouverte/igo2-lib
2 participants
@aziz-access @alecarn