Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(geo): adapt numbers with unit and solve show hide ditanse and area #1504

Merged
merged 6 commits into from
Nov 27, 2023

Conversation

aziz-access
Copy link
Contributor

@aziz-access aziz-access commented Nov 16, 2023

What is the current behavior? (You can also link to an open issue here)

this behavior related to #1499 and #1096

What is the new behavior?

  • adapt numbers with unit changes.
  • solve show hide ligne ditanse and area surface.
  • keep Length and area units after navigating to another tool.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@aziz-access aziz-access added the bug Incorrect or unexpected behaviors // Anomalies de fonctionnement label Nov 16, 2023
@aziz-access aziz-access self-assigned this Nov 16, 2023
@alecarn
Copy link
Collaborator

alecarn commented Nov 21, 2023

@pelord ready for your review

@aziz-access aziz-access requested a review from alecarn November 22, 2023 19:16
@aziz-access aziz-access changed the title fix(geo): adapt numbers with unit changes fix(geo): adapt numbers with unit and solve show hide ditanse and area Nov 22, 2023
@alecarn alecarn added this to the v16.1.0 milestone Nov 24, 2023
Copy link
Member

@pelord pelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to keep the defined units check this video on tool change
chrome_2023-11-27_11-58-08

@pelord
Copy link
Member

pelord commented Nov 27, 2023

The values in the table do not seem to be updated.

@pelord pelord merged commit 09a2f0d into next Nov 27, 2023
4 checks passed
@pelord pelord deleted the measur-tool-change-of-units branch November 27, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Incorrect or unexpected behaviors // Anomalies de fonctionnement
Projects
None yet
3 participants