-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(context): save layer opacity in db #1439
Conversation
packages/context/src/lib/context-manager/shared/context.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job Aziz, je passe la puck à @pelord
visible: layer.visible, | ||
security: layer.security | ||
} as LayerOptions, | ||
layerOptions: layerOptions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated, should be simplified as
layerOptions,
VectorLayerOptions, | ||
VectorTileLayerOptions | ||
VectorTileLayerOptions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra comma
id: String(tool.id), | ||
global: tool.global, | ||
name: tool.name, | ||
component: tool.component |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pourquoi? je ne comprends pas la raison de passer le tool.component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aziz-access nous sommes p-t en présence d'un Partial?
What is the current behavior? (You can also link to an open issue here)
this behavior related to #979 in igo 2
What is the new behavior?
save layer opacity in db
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: