-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(geo, common): Integrate ngx color #1422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aziz-access
added
bug
Incorrect or unexpected behaviors // Anomalies de fonctionnement
in progress
In progress // Développement en cours
labels
Sep 28, 2023
alecarn
reviewed
Sep 28, 2023
packages/common/src/lib/color-picker-form-field/color-picker-form-field.component.ts
Outdated
Show resolved
Hide resolved
packages/common/src/lib/color-picker-form-field/color-picker-form-field.component.ts
Outdated
Show resolved
Hide resolved
alecarn
approved these changes
Sep 28, 2023
@pelord ready for your review |
pelord
requested changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove console.log pls.
packages/geo/src/lib/style/style-modal/layer/style-modal-layer.component.ts
Outdated
Show resolved
Hide resolved
packages/geo/src/lib/style/style-modal/drawing/style-modal-drawing.component.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior? (You can also link to an open issue here)
this behavior integrate ngx-color to solve the issues of color alpha
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: