Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(qcca-theme): ajout de style pour la barre de défilement qc-ca #1400

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

LAMM26
Copy link
Contributor

@LAMM26 LAMM26 commented Sep 21, 2023

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?
The scrollbar has a personnalized color and is thinner.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@LAMM26 LAMM26 requested a review from alecarn September 21, 2023 13:02
}

*::-webkit-scrollbar-thumb {
background: #095797;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Même chose ici, la couleur est disponible dans la palette

Suggested change
background: #095797;
background: base.$blue-normal-piv;

}

*::-webkit-scrollbar-track {
box-shadow: inset 0 0 5px #dae6f0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faudrait utiliser la palette de couleur ou aller chercher directement dans les coleurs officiel du QCCA

Suggested change
box-shadow: inset 0 0 5px #dae6f0;
box-shadow: inset 0 0 5px base.$blue-light;

@@ -0,0 +1,17 @@
@use 'sass:map';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L'importation 'sass:map' ne semble pas utilisé

@alecarn alecarn merged commit b8b9cba into next Sep 22, 2023
4 checks passed
@alecarn alecarn deleted the scrollbar_qcca branch September 22, 2023 14:30
alecarn pushed a commit that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants