Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(geo): add style and change color in feature store #1228

Merged
merged 3 commits into from
May 1, 2023

Conversation

aziz-access
Copy link
Contributor

What is the current behavior? (You can also link to an open issue here)

This update relate to the #925

What is the new behavior?

Change the default color for symbology of features added on the map

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@aziz-access aziz-access self-assigned this Apr 25, 2023
@aziz-access aziz-access added the enhancement New features and improvements // Nouvelles fonctionnalités et améliorations label Apr 25, 2023
@aziz-access aziz-access changed the title fear(geo): add style and change color in feature store feat(geo): add style and change color in feature store Apr 27, 2023
@@ -350,6 +377,9 @@ export class SearchResultAddButtonComponent implements OnInit, OnDestroy{
}
}
},
style: function(feature) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aziz-access . Please, do not create a stylefunction unless you really need it. ==> style: style

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aziz-access I've done the fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@pelord pelord merged commit ce14056 into next May 1, 2023
@pelord pelord deleted the searchResultsChangePointColor branch May 1, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features and improvements // Nouvelles fonctionnalités et améliorations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants