Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datasource): prevent service request when offline #1226

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

pelord
Copy link
Member

@pelord pelord commented Apr 21, 2023

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
On offline app, if a service based layer is created, the app raise an error on getcapabilities or on option service.

What is the new behavior?
Prevent calling service when offline.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord pelord merged commit 1d44c5c into next Apr 21, 2023
@pelord pelord deleted the serviceOffline branch April 21, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant