-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search - Remove the number of results #829 #1157
Conversation
The user can activate true to display the number of results produced once the search has been carried out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename searchResultsNumber by showResultsCount or something like that
do a PR on igo2 to add this config to the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename showValue by showResultsCount
… on config * Search - Remove the number of results #829 * minor refactor / lint * fix getConfig for searchResultsNumber * refactor(search-results): rename config variable. Co-authored-by: karengeo <[email protected]> Co-authored-by: Philippe Lafreniere <[email protected]> Co-authored-by: Pierre-Étienne Lord <[email protected]>
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: