Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search - Remove the number of results #829 #1157

Merged
merged 4 commits into from
Jan 17, 2023
Merged

Conversation

MSPKarengeo
Copy link
Contributor

@MSPKarengeo MSPKarengeo commented Jan 6, 2023

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@MSPKarengeo
Copy link
Contributor Author

The user can activate true to display the number of results produced once the search has been carried out.

Copy link
Member

@pelord pelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename searchResultsNumber by showResultsCount or something like that

do a PR on igo2 to add this config to the documentation.

Copy link
Member

@pelord pelord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename showValue by showResultsCount

@pelord pelord merged commit f20e344 into next Jan 17, 2023
@pelord pelord deleted the noshow_results_icherche branch January 17, 2023 17:14
cbourget pushed a commit that referenced this pull request Mar 21, 2023
… on config

* Search - Remove the number of results #829

* minor refactor / lint

* fix getConfig for searchResultsNumber

* refactor(search-results): rename config variable.

Co-authored-by: karengeo <[email protected]>
Co-authored-by: Philippe Lafreniere <[email protected]>
Co-authored-by: Pierre-Étienne Lord <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants