fix(search-results): hide empty result during typing #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeLafreniere18
requested review from
pelord
and removed request for
pelord
packages/integration/src/lib/search/search-results-tool/search-results-tool.component.ts
Outdated
Show resolved
Hide resolved
PhilippeLafreniere18
approved these changes
Jan 6, 2023
pelord
approved these changes
Jan 17, 2023
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
* fix(search-results): hide empty result during typing * change if condition to show search result component, until the request ended * resolve lint error * fix no results display when term is empty * uncommit toggleTopPanel function * solve lint error * fix request delay on first debounce Co-authored-by: Philippe Lafreniere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the current behavior? (You can also link to an open issue here)
this update relate to the issue 792 on igo2
What is the new behavior?
To hide empty message during typing