Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): Clear search tooltip #1111

Merged
merged 1 commit into from
Oct 26, 2022
Merged

feat(search): Clear search tooltip #1111

merged 1 commit into from
Oct 26, 2022

Conversation

mneige
Copy link
Contributor

@mneige mneige commented Oct 25, 2022

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
When the user types in the search bar, there is a close button to clear the search but no tooltip is associated with the button.

What is the new behavior?
There is a translated tooltip associated with the clear search button "Clear search/Effacer la recherche"

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@mneige mneige linked an issue Oct 25, 2022 that may be closed by this pull request
@pelord pelord changed the base branch from master to next October 25, 2022 17:44
@pelord pelord added the simple label Oct 25, 2022
@pelord pelord merged commit 1b2d1ad into next Oct 26, 2022
@pelord pelord deleted the clearsearch branch October 26, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recherche - Tooltip "Effacer la recherche"
2 participants