Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(arcgis): url remplacement may cause errors if mapserver is not enabled #1072

Merged
merged 7 commits into from
Oct 24, 2022

Conversation

pelord
Copy link
Member

@pelord pelord commented Jun 10, 2022

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
Arcgis Datasource automatically replace the content of the provided url from FeatureServer to Mapserver.
This may cause errors if mapserver is not enabled.

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@pelord pelord marked this pull request as ready for review September 8, 2022 00:18
@pelord pelord added to test Issues that need testing by PO // Demandes qui ont besoin d'être testées par un pilote simple labels Oct 24, 2022
@PhilippeLafreniere18 PhilippeLafreniere18 merged commit 0474418 into next Oct 24, 2022
@pelord pelord deleted the arcgisUrl branch October 26, 2022 14:42
cbourget pushed a commit that referenced this pull request Mar 21, 2023
…abled (#1072)

* fix(arcgis): url remplacement may cause errors if mapserver is not enabled.

* fix(arcgisrest): arcgis service was calling non existing url

Co-authored-by: Pierre-Étienne Lord <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
simple to test Issues that need testing by PO // Demandes qui ont besoin d'être testées par un pilote
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants