Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(draw): Management of the editing of the labels #1059

Merged
merged 7 commits into from
Jun 10, 2022
Merged

feat(draw): Management of the editing of the labels #1059

merged 7 commits into from
Jun 10, 2022

Conversation

kalvinkhuu
Copy link
Contributor

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)

Link to the issue

What is the new behavior?

  1. Added a cancel button with its respective logic
  2. Allowing the user to double click the selected drawing to edit its label
  3. User can now edit the font size and style of the labels of their drawings

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@PhilippeLafreniere18 PhilippeLafreniere18 marked this pull request as draft May 20, 2022 19:12
PhilippeLafreniere18
PhilippeLafreniere18 requested changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@PhilippeLafreniere18 PhilippeLafreniere18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the form-field for font type and size is a little bit big in the igo2 display. Maybe minimize it a bit and place them side by side ?

packages/geo/src/lib/draw/draw/draw-popup.component.html Outdated Show resolved Hide resolved
packages/geo/src/lib/draw/draw/draw.component.html Outdated Show resolved Hide resolved
packages/geo/src/lib/draw/draw/draw.component.html Outdated Show resolved Hide resolved
packages/geo/src/lib/draw/draw/draw.component.html Outdated Show resolved Hide resolved
packages/geo/src/lib/draw/draw/draw.component.html Outdated Show resolved Hide resolved
packages/geo/src/lib/draw/draw/draw.component.ts Outdated Show resolved Hide resolved
packages/geo/src/lib/draw/draw/draw.component.ts Outdated Show resolved Hide resolved
packages/geo/src/lib/draw/draw/draw.component.ts Outdated Show resolved Hide resolved
packages/geo/src/lib/draw/draw/draw.component.ts Outdated Show resolved Hide resolved
packages/geo/src/lib/draw/shared/draw-style.service.ts Outdated Show resolved Hide resolved
@PhilippeLafreniere18 PhilippeLafreniere18 marked this pull request as ready for review June 2, 2022 20:31
PhilippeLafreniere18
PhilippeLafreniere18 requested changes Jun 7, 2022
View reviewed changes
packages/geo/src/lib/draw/draw/draw.component.html Outdated Show resolved Hide resolved
packages/geo/src/lib/draw/draw/draw.component.html Outdated Show resolved Hide resolved
packages/geo/src/lib/draw/draw/draw.component.html Outdated Show resolved Hide resolved
packages/geo/src/lib/draw/draw/draw.component.html Outdated Show resolved Hide resolved
packages/geo/src/lib/draw/draw/draw.component.html Outdated Show resolved Hide resolved
packages/geo/src/lib/draw/draw/draw.component.html Outdated Show resolved Hide resolved
@pelord
Copy link
Member

pelord commented Jun 10, 2022

@PhilippeLafreniere18 1.12 is the target?

@pelord pelord merged commit 2c039e2 into next Jun 10, 2022
@pelord pelord deleted the DessinGestionDesEtiquettes branch June 10, 2022 13:18
cbourget pushed a commit that referenced this pull request Mar 21, 2023
@kalvinkhuu @cbourget
feat(draw): Management of the editing of the labels (#1059)
c43ae61 
* Merge branch 'DrawingGestionOnLabels' into DessinGestionDesEtiquettes

* formatted the html

* format ts file

* Fixed some formatting issues

* Redid design of the inputs box

* Reformatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeLafreniere18 PhilippeLafreniere18 PhilippeLafreniere18 approved these changes

@pelord pelord pelord approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kalvinkhuu @pelord @PhilippeLafreniere18