feat(ogc-filter/dom): allow domain of values to fill ogc-filter selec… #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t / add autocomplete ogc-filter form
3 tasks
3 tasks
pelord
approved these changes
Jun 14, 2022
| export interface DOMOptions { | ||
| name: string; | ||
| url?: string; | ||
| value?: DOMValue[]; |
| for (const domSelector of bundle.domSelectors) { | ||
| let filterDOM; | ||
| for (const domOptions of this.configService.getConfig('dom')) { | ||
| if (domSelector.name === domOptions.name) { |
There was a problem hiding this comment.
Maybe try a match based on a ID instead of the name.. or a combinaison of both.
This was referenced Jun 15, 2022
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
#1044) * feat(ogc-filter/dom): allow domain of values to fill ogc-filter select / add autocomplete ogc-filter form * lint * fix(ogcfilter): fix domSelectors loop * fix(ogc-filter): fix button count and reset filter * fix/refactor(ogc-filters): fix deprecated warning with ngModel/fix reset filter with select * fix(ogc-filters): fix resetFilter on select domSelector * fix(ogc): fix reset select filter * lint * refactor(ogc-filters): association du dom par id * rename variable * rename variables * ui(ogc-filter): make form untouched on clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t / add autocomplete ogc-filter form
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
Domain of value can't be used to fill ogc-filter form.
Autocomplete form is not defined for ogc-filter
Link to : infra-geo-ouverte/igo2#763 and infra-geo-ouverte/igo2#761
What is the new behavior?
You can define a domain (config) to fill in ogc-filter select and autocomplete type
Autocomplete type form can be used to fill domain of values (useful when you have a lot of possibilities)
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information:
DOM can be url http call (with column id and value) or an array of option (id/value)