feat(wakeLockApi): button to prevent the screen lock #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeLafreniere18
requested changes
May 20, 2022
packages/geo/src/lib/map/map-browser/map-browser.component.scss
Outdated
Show resolved
Hide resolved
will be fixed by the update of the lib inside the "assemblage" |
PhilippeLafreniere18
approved these changes
May 24, 2022
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
* feat(wakeLockApi): button to prevent the screen lock * refactor(wakeLock): disable wakelock on blur for non supported browser * i18n(geo): typo * wip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
There is no method available to keep the browser open.
What is the new behavior?
Prevent display sleep and enable wake lock in all Android and iOS web browsers.
On iOS, the Wake Lock API is not supported.
https://developer.mozilla.org/en-US/docs/Web/API/Screen_Wake_Lock_API
On not supported browser, a fake video is used to keep the screen open.
TODO: When the API will be supported by every browser, We should remove the NoSleep.js dependency
and replace it by a WakeLock API implementation.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: