feat(feature-details): open secure docs and images from depot API #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippeLafreniere18
requested changes
Mar 21, 2022
packages/geo/src/lib/feature/feature-details/feature-details.component.ts
Outdated
Show resolved
Hide resolved
PhilippeLafreniere18
approved these changes
Apr 7, 2022
pelord
requested changes
May 2, 2022
pelord
approved these changes
May 2, 2022
|
@LAMM26 Please resolve merge conflicts! Try to merge 1.11.1 |
Should be resolved |
|
@LAMM26 Try merge next into your branch please. Still some conflicts. |
cbourget
pushed a commit
that referenced
this pull request
Mar 21, 2023
) * feat(feature-details): verify credentials for urls in storage API * refactor(feature-details): some optimizations * fix(feature-details): small fixes * refactor(feature-details): fix tags and translations * fix(feature-details): fix logic * fix(feature-details): slice storage url * fixed regex and added click function * changed api regex to config * merge next * fix conflict * repaired bug with strings * configService optional * fix(query): Point with htmlgml2 were not rendered correctly. Co-authored-by: Pierre-Etienne Lord <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What is the current behavior? (You can also link to an open issue here)
URLs to external docs or images present in the getInfo table can sometimes be stored in the depot API and those are currently not validated by the app (unlike the user guides).
What is the new behavior?
Docs and images stored in the depot API can now be accessed in the getInfo table if the user has the credentials to access them.
Other small typo corrections
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications:
Other information: