Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notebook improvements: 02_ml_pipeline.ipynb #32

Open
kate19brown opened this issue Oct 9, 2023 · 0 comments
Open

Notebook improvements: 02_ml_pipeline.ipynb #32

kate19brown opened this issue Oct 9, 2023 · 0 comments

Comments

@kate19brown
Copy link
Contributor

kate19brown commented Oct 9, 2023 •
edited by kaedonkers
Loading

  1. More spacing in text
  2. Avoid italics
  3. More comments in code to explain code
  4. list(falklands_df.columns) is the line necessary - as the output is very long
  5. train/test split - could be clearer - test/train split 20% and 25% is confusing
  6. Explain features even if they are small e.g. %%time
  7. Consider if using sklearn.metrics.confusion_matrix() and sklearn.metrics.ConfusionMatrixDisplay() could make code simplier?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kate19brown