Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: 🦀 fix nightly cargo test-all-features #1424

Merged
merged 1 commit into from
May 21, 2024
Merged

ci: 🦀 fix nightly cargo test-all-features #1424

merged 1 commit into from
May 21, 2024

Conversation

cratelyn
Copy link
Collaborator

example: https://github.com/informalsystems/tendermint-rs/actions/runs/9181862633/job/25249544213?pr=1423

 error: unexpected `cfg` condition value: `grpc-client`
 --> proto/src/lib.rs:3:46
  |
3 | #![cfg_attr(not(any(feature = "grpc-server", feature = "grpc-client")), no_std)]
  |                                              ^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: expected values for `feature` are: `default`, `grpc`, `grpc-server`, `tonic`
  = help: consider adding `grpc-client` as a feature in `Cargo.toml`
  = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration

i noticed this error in ci for #1423, and #1422.

@cratelyn
ci: 🦀 fix nightly cargo test-all-features
52d4b38 
example: https://github.com/informalsystems/tendermint-rs/actions/runs/9181862633/job/25249544213?pr=1423

```
 error: unexpected `cfg` condition value: `grpc-client`
 --> proto/src/lib.rs:3:46
  |
3 | #![cfg_attr(not(any(feature = "grpc-server", feature = "grpc-client")), no_std)]
  |                                              ^^^^^^^^^^^^^^^^^^^^^^^
  |
  = note: expected values for `feature` are: `default`, `grpc`, `grpc-server`, `tonic`
  = help: consider adding `grpc-client` as a feature in `Cargo.toml`
  = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration
```
@cratelyn cratelyn self-assigned this May 21, 2024
@cratelyn cratelyn mentioned this pull request May 21, 2024
Open
erwanor
erwanor approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@erwanor erwanor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had a plan to gate the service client/server impls, but only ended up doing the grpc-server one. LGTM.

This was referenced May 21, 2024
Merged
Merged
@cratelyn cratelyn merged commit 353b9c3 into informalsystems:main May 21, 2024
22 checks passed
@cratelyn cratelyn deleted the kate/fix-nightly-cfg-error branch May 21, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwanor erwanor erwanor approved these changes

Assignees

@cratelyn cratelyn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cratelyn @erwanor