Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: tools workspace is not validated #996

Closed
xla opened this issue Sep 29, 2021 · 0 comments · Fixed by #997
Closed

ci: tools workspace is not validated #996

xla opened this issue Sep 29, 2021 · 0 comments · Fixed by #997
Assignees
@xla
Labels
ci Related to continuous integration enhancement New feature or request technical debt Issues that are important, but not urgent, that should eventually receive attention

Comments

@xla
Copy link
Contributor

xla commented Sep 29, 2021

Except for one set of tests the tools workspace is not considered during ci.

What's the definition of "done" for this issue?

When changes which break any crate in the tools workspace are not accepted do to failing checks in the github workflows.
@xla xla added enhancement New feature or request ci Related to continuous integration technical debt Issues that are important, but not urgent, that should eventually receive attention labels Sep 29, 2021
@xla xla self-assigned this Sep 29, 2021
@xla xla mentioned this issue Sep 29, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xla xla

Labels
ci Related to continuous integration enhancement New feature or request technical debt Issues that are important, but not urgent, that should eventually receive attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Build and check tools informalsystems/tendermint-rs
1 participant
@xla