Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compatibility of misbehaviour evidence JSON serialization with CometBFT v0.37.10 and v0.38.11 #1461

Open
romac opened this issue Aug 12, 2024 · 0 comments

Comments

@romac
Copy link
Member

romac commented Aug 12, 2024

In CometBFT v0.37.10 and v0.38.11, the name of the fields of the DuplicateVoteEvidence and LightClientAttackEvidence structs when serialized to JSON have changed from PascalCase to snake_case.

As Hermes uses those structs to process and report misbehaviour evidence, we should make sure that we can still do so with those versions using snake_case, while keeping backward compatibility with chains running previous versions using UpperCamelCase.

@romac romac changed the title Ensure we can report misbehavior evidence to CometBFT v0.37.10 and v0.38.11 Ensure compatibility of misbehaviour evidence JSON serialization with CometBFT v0.37.10 and v0.38.11 Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant