Replace deprecated rust-crypto dep with RustCrypto org packages #719
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #352
Closes: #720
Description
Our security audits are starting to fail:
https://github.com/informalsystems/ibc-rs/runs/2006092577?check_suite_focus=true
After a brief search, I choose to use crates from https://github.com/RustCrypto. Their crates seem to be maintained (repos had activity within the last few hours/days).
Note that we're still depending on rust-crypto transitively viah/t @romac for suggestingbitcoin-wallet v1.1.0
. hence the security audit still fails.tiny-bip39
to replacebitcoin-wallet
.ics23
since we didn't use it and triggered audit failure (see RUSTSEC-2020-0146: arr! macro erases lifetimes #720). Maintainers ofics23
are aware of the problem (ics23/#37).For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.