Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New optional flags for the command query connections #2391

Merged
merged 7 commits into from
Jul 13, 2022

Conversation

ljoss17
Copy link
Contributor

@ljoss17 ljoss17 commented Jul 11, 2022

Closes: #2310

Description

This PR adds two optional flags for the command query connections:

  • --counterparty-chain allows to filter the connections displayed with a counterparty chain id.
  • --verbose displays additional information, such as the client and counterparty client of the connections.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests: integration (for Hermes) or unit/mock tests (for modules).
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@ljoss17 ljoss17 requested a review from adizere as a code owner July 11, 2022 13:56
@romac romac merged commit 7e19465 into master Jul 13, 2022
@romac romac deleted the luca_joss/optional_flags_query_connections branch July 13, 2022 10:00
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
…ms#2391)

* Added 'verbose' and 'counterparty-chain' flags to 'query connections' command

* Updated Hermes guide with new optional flags for 'query connections' command

* Added changelog entry

* Updated ADR 010 Status to reflect new PR for 'query connections' optional flags

* Fixed date error in ADR 010

* Fixed changelog entry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add optional flags --counterparty-chain and --verbose to hermes query connections
2 participants