Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overflow if ctx.host_current_height().revision_height < ctx.host_chain_history_size() #685

Closed
5 tasks
vitorenesduarte opened this issue Feb 19, 2021 · 0 comments · Fixed by #686
Closed
5 tasks
Assignees
Labels
A: bug Admin: something isn't working
Milestone

Comments

@vitorenesduarte
Copy link
Contributor

vitorenesduarte commented Feb 19, 2021

Crate

modules

Summary of Bug

If ctx.host_current_height().revision_height < ctx.host_chain_history_size(), the following will overflow:

https://github.com/informalsystems/ibc-rs/blob/ae36bba8db5404243e28566f2a7ce2dbef1640ae/modules/src/ics03_connection/handler/verify.rs#L200-L201

This issue was found during the MBT work (#546), after initializing the MockContext with max_history_size = usize::MAX.

Version

ae36bba


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
None yet
2 participants