Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename parts to part_set_header #103

Closed
5 tasks
adizere opened this issue Oct 25, 2020 · 0 comments · Fixed by informalsystems/hermes#355
Closed
5 tasks

Rename parts to part_set_header #103

adizere opened this issue Oct 25, 2020 · 0 comments · Fixed by informalsystems/hermes#355

Comments

@adizere
Copy link
Contributor

adizere commented Oct 25, 2020

Crate

modules

Summary of Bug

In the upcoming version of tendermint-rs (most likely RC2) the parts field in block_id is renamed to part_set_header.
Some of our tests will fail once we start depending on this version.

Part of the fix will involve adapting a JSON file we use in our tests. See here the diff on how the fix should look like.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@ancazamfir ancazamfir mentioned this issue Nov 2, 2020
Merged
5 tasks
@adizere adizere linked a pull request Nov 6, 2020 that will close this issue
Implement client update and fix client create CLIs informalsystems/hermes#355
Merged
5 tasks
@adizere adizere closed this as completed Nov 6, 2020
@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
@romac
Merge pull request cosmos#103 from confio/split-std
8260360 
Rust: Split `std` feature into `std` and `host-functions`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement client update and fix client create CLIs informalsystems/hermes
1 participant
@adizere