Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on "message" events #3190

Closed
5 tasks
Tracked by #3199
, #2850
...
plafer opened this issue Mar 23, 2023 · 1 comment · Fixed by #3323
Closed
5 tasks
Tracked by #3199
, #2850
...

Remove dependency on "message" events #3190

plafer opened this issue Mar 23, 2023 · 1 comment · Fixed by #3323
Assignees
@romac @ljoss17
Labels
A: critical Admin: critical or important E: non-cosmos External: related to non-Cosmos chains E: wasm External: related to WASM and CosmWasm support I: logic Internal: related to the relaying logic I: protocol Internal: related to IBC protocol changes (eg. v2 update) I: rpc Internal: related to (g)RPC
Milestone
v1.6

Comments

@plafer
Copy link
Contributor

plafer commented Mar 23, 2023

Summary

Hermes currently uses events of type "message", which are SDK-specific. In my current understanding, since they are not technically IBC-specific, hermes should not rely on them to relay datagrams.

Problem Definition

ibc-rs is now forced to emit these events too for hermes to be able to relay messages coming from an ibc-rs chain.

Related: cosmos/ibc-rs#563

Acceptance Criteria

ibc-rs doesn't need to emit these events anymore for hermes to successfully relay datagrams.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@plafer plafer mentioned this issue Mar 23, 2023
Closed
@romac
Copy link
Member

romac commented Mar 24, 2023

Related #2809

@github-project-automation github-project-automation bot moved this to 🩹 Triage in Hermes Mar 24, 2023
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 📥 Todo in Hermes Mar 27, 2023
@seanchen1991 seanchen1991 mentioned this issue Mar 27, 2023
Closed
3 tasks
@seanchen1991 seanchen1991 added the I: dependencies Internal: related to dependencies label Mar 27, 2023
@romac romac added the A: critical Admin: critical or important label Mar 28, 2023
@romac romac added this to the v1.5 milestone Mar 28, 2023
@romac romac added I: logic Internal: related to the relaying logic I: rpc Internal: related to (g)RPC E: non-cosmos External: related to non-Cosmos chains I: protocol Internal: related to IBC protocol changes (eg. v2 update) E: wasm External: related to WASM and CosmWasm support and removed I: dependencies Internal: related to dependencies labels Mar 28, 2023
This was referenced Apr 17, 2023
Closed
Closed
@seanchen1991 seanchen1991 moved this from 📥 Todo to 🏗 In progress in Hermes Apr 17, 2023
@seanchen1991 seanchen1991 linked a pull request Apr 17, 2023 that will close this issue
Poll the chain for new blocks instead of using the WebSocket #3209
Closed
7 tasks
@romac romac mentioned this issue May 9, 2023
Merged
7 tasks
@seanchen1991 seanchen1991 moved this from 🏗 In progress to 👀 In review in Hermes May 17, 2023
@romac romac modified the milestones: v1.5, v1.6 May 23, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Hermes Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romac romac

@ljoss17 ljoss17

Labels
A: critical Admin: critical or important E: non-cosmos External: related to non-Cosmos chains E: wasm External: related to WASM and CosmWasm support I: logic Internal: related to the relaying logic I: protocol Internal: related to IBC protocol changes (eg. v2 update) I: rpc Internal: related to (g)RPC
Projects
Hermes
Status: ✅ Done
Milestone
v1.6
4 participants
@romac @seanchen1991 @plafer @ljoss17