Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit the light client attack evidence to the reference chain #2772

Closed
1 of 6 tasks
Tracked by #3198
, #1999 ,  #3175
...
ancazamfir opened this issue Oct 27, 2022 · 2 comments · Fixed by #3224
Closed
1 of 6 tasks
Tracked by #3198
, #1999 ,  #3175
...

Submit the light client attack evidence to the reference chain #2772

ancazamfir opened this issue Oct 27, 2022 · 2 comments · Fixed by #3224
Assignees
@romac
Labels
I: dependencies Internal: related to dependencies O: security Objective: cause to enhance security and improve safety
Milestone
v1.5

Comments

@ancazamfir
Copy link
Collaborator

ancazamfir commented Oct 27, 2022 •
edited by romac
Loading

Summary

(cc: @mzabaluev)

When enabled for misbehaviour, hermes monitors on-chain client updates and verifies the submitted headers comparing with headers it retrieves from its RPC node. If it detects conflicting headers, it submits the MisbehaviourMsg to the chain hosting the IBC client.
In addition, hermes should submit the evidence to the reference chain.

Problem Definition

The reference chain does not receive the evidence.

Proposal

Submit LightClientAttackEvidence evidence from the reference chain runtime when running check_misbehaviour.
Note: we need to wait for the implementation of LightClientAttackEvidence in tendermint-rs.

Acceptance Criteria

  • Update the feature page of the guide

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate milestone (priority) applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@mzabaluev mzabaluev mentioned this issue Oct 27, 2022
Closed
@adizere adizere added this to the v1.3 milestone Oct 31, 2022
@adizere adizere added this to Hermes Dec 13, 2022
@adizere adizere moved this to 📋 Backlog in Hermes Dec 13, 2022
@seanchen1991 seanchen1991 modified the milestones: v1.3, Backlog Dec 13, 2022
@seanchen1991 seanchen1991 moved this from 📋 Backlog to 🩹 Triage in Hermes Dec 14, 2022
@romac romac added the O: security Objective: cause to enhance security and improve safety label Dec 19, 2022
@romac
Copy link
Member

romac commented Dec 19, 2022

Blocked on informalsystems/tendermint-rs#1219

@romac romac added I: dependencies Internal: related to dependencies A: blocked Admin: blocked by another (internal/external) issue or PR labels Dec 19, 2022
@seanchen1991 seanchen1991 moved this from 🩹 Triage to 🛑 Blocked in Hermes Dec 22, 2022
@adizere adizere mentioned this issue Jan 10, 2023
Closed
6 tasks
@romac
Copy link
Member

romac commented Jan 10, 2023

I just opened a PR on tendermint-rs which fills in the LightClientAttackEvidence structs, etc: informalsystems/tendermint-rs#1259

@romac romac moved this from 🛑 Blocked to 🏗 In progress in Hermes Jan 10, 2023
@romac romac removed the A: blocked Admin: blocked by another (internal/external) issue or PR label Jan 10, 2023
@seanchen1991 seanchen1991 moved this from 🏗 In progress to 🛑 Blocked in Hermes Jan 10, 2023
@romac romac added the A: blocked Admin: blocked by another (internal/external) issue or PR label Jan 10, 2023
@romac romac modified the milestones: v1.3, v1.4 Jan 27, 2023
@seanchen1991 seanchen1991 removed this from the v1.4 milestone Mar 23, 2023
@seanchen1991 seanchen1991 added this to the v1.5 milestone Mar 23, 2023
@romac romac mentioned this issue Mar 28, 2023
Closed
3 tasks
@ancazamfir ancazamfir mentioned this issue Apr 4, 2023
Closed
16 tasks
@ancazamfir ancazamfir changed the title Submit the light client attack evidence to the reference chain also Submit the light client attack evidence to the reference chain Apr 4, 2023
@romac romac mentioned this issue Apr 4, 2023
Merged
7 tasks
@romac romac moved this from 🛑 Blocked to 🏗 In progress in Hermes Apr 4, 2023
@romac romac removed the A: blocked Admin: blocked by another (internal/external) issue or PR label Apr 4, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Hermes May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romac romac

Labels
I: dependencies Internal: related to dependencies O: security Objective: cause to enhance security and improve safety
Projects
Hermes
Status: ✅ Done
Milestone
v1.5
5 participants
@romac @mzabaluev @adizere @seanchen1991 @ancazamfir