Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support simultaneously binaries with/without genesis sub-command #7

Closed
crodriguezvega opened this issue Mar 24, 2023 · 2 comments
Closed

Comments

@crodriguezvega
Copy link

Since Cosmos SDK v0.47 the genesis commands have all been grouped under a genesis top level sub-command. See issue and PR in Cosmos SDK repository.

It would be nice if gm could differentiate whether the chain binary has the genesis commands in the top level directly or under the genesis sub-command.

@greg-szabo
Copy link
Member

Oh, you guys and your CLI rearrangements. :D

Great point, thanks for opening the issue, Carlos. Most probably we'll do some kind of "fallback" implementation (as we did with the tendermint sub-command before). Unfortunately, we ran into network binaries that removed the --long parameter from the version command, hence it's not always trivial to query the SDK version used in the binary. (Injective, I'm looking at you...)

If you could strongly encourage downstream developers to keep the flags the core teams provide, please apply the pressure. ;)

@greg-szabo
Copy link
Member

Fixed in #8 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants