New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracing fixes for error span #297

Merged

mphillips-infoblox merged 1 commit into master from FixForErrorSpan

Nov 23, 2021

Contributor

mphillips-infoblox commented Nov 19, 2021

Fixes for adding error spans caused by bug in open telemetry collector.

See discussion here: open-telemetry/opentelemetry-collector#70

code should be added as a census.status_code tag.
message should be added as a census.status_description tag.
If code is NOT StatusCodeOK, then add error tag with value true


          Tracing fixes for error span

506695c

mphillips-infoblox requested review from drewwells, Evgeniy-L and kd7lxl

November 19, 2021 01:46

kd7lxl approved these changes

View reviewed changes

tracing/span.go

               //AddErrorSpan adds error into span
               func AddErrorSpan(span *trace.Span, err error) error {
-              	var code int32 = trace.StatusCodeUnknown
+              	var code int32 = trace.StatusCodeOK
               	status, ok := status.FromError(err)

Contributor

kd7lxl Nov 19, 2021

The reuse of status here from module to variable makes the code harder to understand.

mphillips-infoblox merged commit ee3a065 into master

Calebjh deleted the FixForErrorSpan branch

July 21, 2022 20:14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet