Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ready route to inputs.influxdb_v2_listener #8133

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

eraac
Copy link
Contributor

@eraac eraac commented Sep 16, 2020

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Following this discussion #7828 (comment), that can be great if this come with 1.16

All credits for @magichair, I only revert the commit who remove the ready route

Thanks!

@ssoroka
Copy link
Contributor

ssoroka commented Sep 17, 2020

this endpoint is deprecated and was specifically removed. Any comments on why it should be added back in?

@magichair
Copy link
Contributor

@ssoroka is there a deprecation note I'm missing? https://docs.influxdata.com/influxdb/v2.0/api/#tag/Ready still looks fully formed and planned for InfluxDB v2. The original "removal" was more a "don't put it in the first version of this plugin if we don't need it"-type choice.

@ssoroka
Copy link
Contributor

ssoroka commented Sep 17, 2020

Perhaps I misunderstood. I was under the impression it's not used anymore, so I'm curious where this use case is coming from. I'm not against adding this in. Nevermind. This is supported by InfluxDB and there's no reason not to proxy support for the request.

@ssoroka ssoroka merged commit ce13350 into influxdata:master Sep 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants