Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sumo Logic output plugin #8023

Merged
merged 4 commits into from
Sep 10, 2020
Merged

Sumo Logic output plugin #8023

merged 4 commits into from
Sep 10, 2020

Conversation

pmalek-sumo
Copy link
Contributor

This PR adds an output plugin to send data to Sumo Logic

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@reimda
Copy link
Contributor

reimda commented Sep 3, 2020

Hi @pmalek-sumo, thanks for the PR. We have a backlog of new plugins but @ssoroka or I will try to review this soon.

@pmalek-sumo
Copy link
Contributor Author

@reimda Awesome. Thanks!

@sjwang90
Copy link
Contributor

sjwang90 commented Sep 3, 2020

@pmalek-sumo If you'd like to submit this as external plugin in the meantime that would be great. You and others would be able to start using the plugin with Telegraf sooner without waiting for review. Here's more information on external plugins.

@sjwang90
Copy link
Contributor

sjwang90 commented Sep 4, 2020

Hey @pmalek-sumo. If you're an employee of Sumo Logic, do you think you and any other employees involved in building things for Influx can sign the Corporate CLA?

ssoroka
ssoroka reviewed Sep 8, 2020
View reviewed changes
plugins/outputs/sumologic/sumologic.go Outdated
URL string `toml:"url"`
Timeout internal.Duration `toml:"timeout"`
Method string `toml:"method"`
MaxRequstBodySize int `toml:"max_request_body_size"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a config.Size type that might be nice for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't see this. Nice! Changed

@ssoroka
Copy link
Contributor

ssoroka commented Sep 9, 2020

Any idea what's going on with ci macdeps test? it seems like it's running against SumoLogic CI instead of InfluxData?

@perk-sumo
Copy link

perk-sumo commented Sep 9, 2020 •
edited
Loading

Yeah - all of the CircleCI tests were run against SumoLogic org and not the Telegraf InfluxData one actually.
We use free plan ATM so we can't build macdeps.

@pmalek-sumo
Copy link
Contributor Author

CircleCI project was disconnected from Sumo Logic's repository. I can see the jobs are running now under influx's org.

@perk-sumo
Copy link

@sjwang90 we've just sent signed CCLA to [email protected]

@ssoroka ssoroka merged commit e9dcade into influxdata:master Sep 10, 2020
@pmalek-sumo pmalek-sumo deleted the sumologic-output-plugin-pr branch September 10, 2020 15:03
@sjwang90 sjwang90 added this to the 1.16.0 milestone Sep 10, 2020
pmalek-sumo added a commit to SumoLogic/telegraf that referenced this pull request Sep 28, 2020
@pmalek-sumo @pmalek
Sumo Logic output plugin (influxdata#8023)
f64a4c6
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@pmalek-sumo
Sumo Logic output plugin (influxdata#8023)
5bcd34a
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@pmalek-sumo
Sumo Logic output plugin (influxdata#8023)
da76f43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssoroka ssoroka ssoroka approved these changes

Assignees
No one assigned
Labels
new plugin
Projects
None yet
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@pmalek-sumo @reimda @sjwang90 @ssoroka @perk-sumo @pmalek