Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-image make target #8005

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

pmalek-sumo
Copy link
Contributor

COMMIT doesn't seem to be defined anywhere which causes:

docker build -f scripts/stretch.docker -t "telegraf:" .
invalid argument "telegraf:" for "-t, --tag" flag: invalid reference format
See 'docker build --help'.
make: *** [docker-image] Error 125

whereas commit is defined in https://github.com/influxdata/telegraf/blob/master/Makefile#L10

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@pmalek-sumo pmalek-sumo changed the title Fix docker-image make target (#2) Fix docker-image make target Aug 19, 2020
@sjwang90
Copy link
Contributor

Thanks for the contribution. We'll take a look at the PR and let you know if we have any comments.

@pmalek-sumo
Copy link
Contributor Author

Actually I'm not sure if we'd like to keep maintaining this as the make target that is referred in scripts/stretch.docker: go-install doesn't exist in the repo anymore.

It was removed in #7759.

Maybe we should just remove the remnants of the previous build scripts/targets?

@reimda
Copy link
Contributor

reimda commented Sep 3, 2020

Thanks for the PR.

#8051 restored the go-install make target, so this fix is useful.

@reimda reimda merged commit 843ea4b into influxdata:master Sep 3, 2020
@pmalek-sumo pmalek-sumo deleted the fix-docker-image-target branch September 3, 2020 15:40
@sjwang90 sjwang90 added this to the 1.15.3 milestone Sep 3, 2020
ssoroka pushed a commit that referenced this pull request Sep 11, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants