shim logger improvements #7865
Merged
shim logger improvements #7865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reimda
suggested changes
Jul 20, 2020
| } | ||
|
|
||
| // setLoggerOnPlugin used to be called setLogIfExist | ||
| func setLoggerOnPlugin(i interface{}, log telegraf.Logger) { |
There was a problem hiding this comment.
Why rename this when it's copied verbatim from models/log.go? I don't particularly like the name setLogIfExist but it should match models/log.go. If you're going to rename it, change both places.
There was a problem hiding this comment.
I like this suggestion.
reimda
approved these changes
Jul 22, 2020
ssoroka
added a commit
that referenced
this pull request
Jul 22, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log telegraf.Loggerif it's defined on plugins before calling plugin.Init() to avoid panics from plugins that expect to use it.