Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close file to ensure it has been flushed #7819

Merged
merged 1 commit into from
Jul 10, 2020
Merged

Close file to ensure it has been flushed #7819

merged 1 commit into from
Jul 10, 2020

Conversation

danielnelson
Copy link
Contributor

This is an attempt to fix the intermittent test case:

2020/07/10 15:10:08 D! [] Tail added for "/var/folders/pt/0xykrh9j62g34sc7znh47kbc0000gn/T/643693879"
2020/07/10 15:10:08 E! [] Malformed log line in "/var/folders/pt/0xykrh9j62g34sc7znh47kbc0000gn/T/643693879": ["cpu mytag= foo usage_idle= 100"]: metric parse error: expected field at 1:11: "cpu mytag= foo usage_idle= 100"
--- FAIL: TestTailBadLine (0.00s)
    tail_test.go:54: 
        	Error Trace:	tail_test.go:54
        	Error:      	"2020/07/10 15:10:08 D! [] Tail removed for "/var/folders/pt/0xykrh9j62g34sc7znh47kbc0000gn/T/643693879"
        	            	" does not contain "Malformed log line"
        	Test:       	TestTailBadLine
FAIL
FAIL	github.com/influxdata/telegraf/plugins/inputs/tail	0.252s

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@danielnelson danielnelson added this to the 1.15.0 milestone Jul 10, 2020
@danielnelson danielnelson merged commit 51f6cc3 into master Jul 10, 2020
@danielnelson danielnelson deleted the fix-tail-test-race branch July 10, 2020 17:59
danielnelson added a commit that referenced this pull request Jul 10, 2020
@danielnelson
Close file to ensure it has been flushed (#7819)
c8cdd70 
(cherry picked from commit 51f6cc3)
@danielnelson danielnelson mentioned this pull request Jul 10, 2020
Merged
3 tasks
rhajek pushed a commit to bonitoo-io/telegraf that referenced this pull request Jul 13, 2020
@danielnelson @rhajek
Close file to ensure it has been flushed (influxdata#7819)
cb26581
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@danielnelson
Close file to ensure it has been flushed (influxdata#7819)
2b6e87d
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@danielnelson
Close file to ensure it has been flushed (influxdata#7819)
6378a87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssoroka ssoroka ssoroka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.0
Development

Successfully merging this pull request may close these issues.
2 participants
@danielnelson @ssoroka