Send metrics in FIFO order #7814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Metrics are send from older to newer metrics, even when outputs is failing. In case of buffer full, we still drop the oldest metrics, but non-dropped metrics are send in the order they are received. Signed-off-by: Pierre Fersing <[email protected]>
danielnelson
approved these changes
Jul 10, 2020
ssoroka
approved these changes
Jul 13, 2020
reimda
approved these changes
Jul 13, 2020
danielnelson
pushed a commit
that referenced
this pull request
Jul 14, 2020
Metrics are send from older to newer metrics, even when outputs is failing. In case of buffer full, we still drop the oldest metrics, but non-dropped metrics are send in the order they are received. (cherry picked from commit 3ec3f1b)
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
Metrics are send from older to newer metrics, even when outputs is failing. In case of buffer full, we still drop the oldest metrics, but non-dropped metrics are send in the order they are received.
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Metrics are send from older to newer metrics, even when outputs is failing. In case of buffer full, we still drop the oldest metrics, but non-dropped metrics are send in the order they are received.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #5633 (comment), here the PR :)
closes #5633
Required for all PRs: