Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counter type to perfmon collector #7712

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

denzilribeiro
Copy link
Contributor

@denzilribeiro denzilribeiro commented Jun 22, 2020

Counter type enables understanding of how to visualize a performance counter as there are different types of counters. Without which you have to have knowledge of what type each counter is.
Adding perfmon counter type to description at https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.performancecountertype?view=dotnet-plat-ext-3.1

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Adding perfmon counter type description at https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.performancecountertype?view=dotnet-plat-ext-3.1
Counter type enables understanding of how to visualize a performance countner
@danielnelson danielnelson added this to the 1.15.0 milestone Jun 23, 2020
@danielnelson danielnelson added area/sqlserver feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Jun 23, 2020
@danielnelson danielnelson merged commit dd3ff0e into influxdata:master Jun 23, 2020
rhajek pushed a commit to bonitoo-io/telegraf that referenced this pull request Jul 13, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/sqlserver feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants