feat: add additional tags/fields to pod metrics #7691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've removed My thoughts were that we can hide / discourage it's use from the README and deprecate in favour of Would like feedback |
ssoroka
approved these changes
Jun 16, 2020
danielnelson
suggested changes
Jun 16, 2020
There was a problem hiding this comment.
On the terminated_reason field, make it as deprecated and follow the pattern in https://github.com/influxdata/telegraf/wiki/Deprecation#deprecate-metrics
danielnelson
added
the
feat
|
Done. Thank you, @danielnelson |
rawkode
force-pushed
the
feat/improve-pod-understanding
branch
from
ab50020
to
fb4e264
Compare
danielnelson
approved these changes
Jun 16, 2020
|
Thanks, @danielnelson |
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add state reason, which can eventually deprecated
terminated_reason, to pod_container metrics; as well as a tag to represent the readiness of the container.Required for all PRs: