Add starlark processor #7660
Merged
Add starlark processor #7660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the metric is modified in place, it was just to hard to predict what the output would be.
reimda
suggested changes
Jun 10, 2020
There was a problem hiding this comment.
If there's an error when calling the script we write the details to the logfile. Many cases in the unit tests (TestApply and TestMetric) have "expected: []telegraf.Metric{}" when there is an error in the script but they don't check the error in the log. Could we have the table tests verify that the error was sent to the logfile? The table test structs would need to add a field like expected_error_message and then the test code would need to compare it with plugin.Log.
For example, the test at starlark_test.go line 562 should check that the log says "Error calling Starlark: line 2: tag value must be a string" or something similar.
ssoroka
suggested changes
Jun 10, 2020
reimda
approved these changes
Jun 23, 2020
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review at long last, special thanks to @srebhan for the help.
closes #7194
closes #3709
Required for all PRs: