Flaky shim test #7656
Merged
Flaky shim test #7656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
suggested changes
Jun 9, 2020
|
|
||
| // we can get stuck if stdout gets clogged up and nobody's reading from it. | ||
| // make sure we keep it going | ||
| func readUntilEmpty(r *bufio.Reader) { |
There was a problem hiding this comment.
Shouldn't the shim code we are testing be doing this?
There was a problem hiding this comment.
no, because this is the read end of the out pipe coming from the shim.
danielnelson
approved these changes
Jun 9, 2020
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-patch was seeing this fail about 1 in 50.
now passes 10000 test runs with no failures.