Add missing nvme attributes to smart plugin #7575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@piter75 Can you rebase this pull request against master to hopefully clear up the test failure. |
danielnelson
added
area/smart
feat
piter75
force-pushed
the
add-missing-nvme-attributes
branch
from
270dc0b
to
aa6e30d
Compare
|
@danielnelson it seems better now - tests passed - but there are some issues with packaging. |
piter75
force-pushed
the
add-missing-nvme-attributes
branch
from
aa6e30d
to
b6a5db6
Compare
|
@danielnelson another rebase on master and it is green finally ;-) |
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds additional nvme specific attributes to smart plugin.
The attributes are verified with NVMe Specification 1.4 and tested with Crucial MP510.
Required for all PRs:
There is no mention of specific attributes in smart README file.